undefined_name/School_Project
3
1
Fork 0
Code Issues 9 Pull Requests Projects 1 Releases 4 Wiki Activity

ScreenLevelFinish #64

Merged
Mat_02 merged 11 commits from ScreenLevelFinish into master 2023-05-18 19:03:56 +02:00
Conversation 0 Commits 11 Files Changed 5 +45 -2
Mat_02 commented 2023-05-17 20:36:20 +02:00
Member
Copy Link

Make a screen when the level is finish and also change the button play for select a difficulty

Make a screen when the level is finish and also change the button play for select a difficulty
Mat_02 added 4 commits 2023-05-17 20:36:22 +02:00
Branch done
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
e1f7d7a729
Mat_02 added 2 commits 2023-05-17 23:38:58 +02:00
Done the select difficulty button
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
f625ec36a4
tonitch requested changes 2023-05-17 23:54:09 +02:00
tonitch left a comment
Owner
Copy Link

L'écran de fin donne super bien bon boulot !

L'écran de fin donne super bien bon boulot !
app/src/main/java/school_project/Menu/MenuAccueil.java
@ -32,0 +31,4 @@
SlctDifficulty.setOnAction(event1 -> MapGenerator.generate(MapGenerator.Difficulty.Medium));
break;
case "Difficult":
SlctDifficulty.setOnAction(event1 -> MapGenerator.generate(MapGenerator.Difficulty.Difficult));
tonitch commented 2023-05-17 23:53:33 +02:00
Owner
Copy Link

Le MapGenerator.generate() retourne une Map
Cette Map doit ensuite être chargée par GameUI(Map)

Il faudrait du coup

SlctDifficulty.setOnAction(event1 -> Controller.switchRoot(new GameUI(MapGenerator.generate(MapGenerator.Difficulty.Difficult)));
Le `MapGenerator.generate()` retourne une `Map` Cette Map doit ensuite être chargée par `GameUI(Map)` Il faudrait du coup ```java SlctDifficulty.setOnAction(event1 -> Controller.switchRoot(new GameUI(MapGenerator.generate(MapGenerator.Difficulty.Difficult))); ```
Mat_02 marked this conversation as resolved
app/src/main/java/school_project/Menu/ScreenLevelFinish.java
@ -0,0 +12,4 @@
public class ScreenLevelFinish extends StackPane {
public ScreenLevelFinish(){
tonitch commented 2023-05-17 23:47:08 +02:00
Owner
Copy Link

Peut être que tu peux ajouter le numéro du niveau dans le constructeur pour l'afficher et demander soit si ils veulent le retenter, soit jouer au suivant.

Remarque, pour les niveaux généré aléatoirement à la place du niveau il faudrait avoir l'objet Map du niveau passé dans le constructeur pour rédémarer le niveau ^

Peut être que tu peux ajouter le numéro du niveau dans le constructeur pour l'afficher et demander soit si ils veulent le retenter, soit jouer au suivant. Remarque, pour les niveaux généré aléatoirement à la place du niveau il faudrait avoir l'objet Map du niveau passé dans le constructeur pour rédémarer le niveau ^
tonitch added 1 commit 2023-05-18 00:12:00 +02:00
Avoid the java error
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
fbaa79d35e
Mat_02 added 3 commits 2023-05-18 17:34:52 +02:00
Changes by tonitch
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
9ff205b4de
tonitch approved these changes 2023-05-18 18:47:32 +02:00
tonitch left a comment
Owner
Copy Link

bien ouéj

bien ouéj
Mat_02 added 1 commit 2023-05-18 19:02:06 +02:00
Fixing merge conflict
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
7e033ef7d2
tonitch approved these changes 2023-05-18 19:02:32 +02:00
Mat_02 merged commit 391d94afbe into master 2023-05-18 19:03:56 +02:00
tonitch deleted branch ScreenLevelFinish 2023-05-18 19:31:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tonitch
Labels
Clear labels   
Important

Doit absolument être fait

  
Moins important

   
Pas important

   
bug

Something is not working

  
done

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
suppléments

à faire si on a le temps

  
wontfix

This won't be fixed

No Label
Important
Moins important
Pas important
bug
done
duplicate
enhancement
help wanted
invalid
question
suppléments
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: undefined_name/School_Project#64
No description provided.
Delete Branch "ScreenLevelFinish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?