undefined_name/School_Project
3
1 Fork 0
Code Issues 9 Pull Requests Projects 1 Releases 4 Wiki Activity

menu #43

Merged
Mat_02 merged 20 commits from menu into master 2023-05-09 15:52:14 +02:00
Conversation 3 Commits 20 Files Changed 6
+172 -10
Mat_02 commented 2023-05-05 11:57:51 +02:00
Member
Copy link
Copy source

Make the interface for the game :
The MenuAcceuil is the fisrt page that the user will see
and The MenuLevel generate the Interface to show all the button to access to all level
TODO : Make levels and link them to buttons

Make the interface for the game : The MenuAcceuil is the fisrt page that the user will see and The MenuLevel generate the Interface to show all the button to access to all level TODO : Make levels and link them to buttons
Mat_02 added 15 commits 2023-05-05 11:57:52 +02:00
beginning of the final interface
continuous-integration/drone/push Build is passing
Details
25a6782f3c
Sub element from Controller to a new class 075bdd9338
Make an array for buttons and add a constructor ce99e1faf9
forget to update syntaxe with the array 24a7a73f36
Clear the method CreateMenu to make a new class with the same role 02b4ab8a35
Clear CreateLevel1 to make a new class d455b7f450
clear CreateLevelMenu2 and all object useless in Controller
continuous-integration/drone/push Build is failing
Details
ee0350c251
Make a package for all the Menu class 644af67a55
Finishing MenuAcceuil b4b89bcd86
Affichage des boutons pour les levels ok dc5da4956a
Finish initiate all the button in the gridPane For MenuLevel a076ca12cb
Finish initiate all the button in the gridPane For MenuLevel 7ac860850c
Finish initiate all the button in the gridPane For MenuLevel
continuous-integration/drone/push Build is failing
Details
a43e3b150a
Make operational and also organize all the buttons
continuous-integration/drone/push Build is passing
Details
8110a93910
Finally finish the menu
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
a3ad448fba
tonitch added 1 commit 2023-05-05 12:11:21 +02:00
Merge branch 'master' into menu
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
752c722b0c
Mat_02 added 1 commit 2023-05-05 12:18:59 +02:00
Add the picture of background
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
1af5db700e
tonitch approved these changes 2023-05-05 12:35:46 +02:00
tonitch left a comment
Owner
Copy link
Copy source

super work, just some comments

super work, just some comments
app/src/main/java/school_project/Controller.java
@@ -25,0 +24,4 @@
root = new MenuAcceuil();
stage = primaryStage;
stage.setTitle("ROAD TO MASTER");
stage.setScene(new Scene(root));
tonitch commented 2023-05-05 12:18:04 +02:00
Owner
Copy link
Copy source

tu pourrais faire un appel à #L33 (switchRoot) dans un premier temps ca ne changer rien mais si on change la façon de changer de scene un moment ca sera alors plus cohérent!

tu pourrais faire un appel à #L33 (switchRoot) dans un premier temps ca ne changer rien mais si on change la façon de changer de scene un moment ca sera alors plus cohérent!
tonitch commented 2023-05-07 10:45:21 +02:00
Owner
Copy link
Copy source

en gros au lieu de faire

        stage.setScene(new Scene(root));

Tu pourrais faire

        switchRoot(root);

Ca ne changerait pas grand chose pour l'instant mais si plus tard dans le code on a besoin de changer le fonctionnement de Scene par expemple, alors ca serait plus simple à changer.

en gros au lieu de faire ```java stage.setScene(new Scene(root)); ``` Tu pourrais faire ```java switchRoot(root); ``` Ca ne changerait pas grand chose pour l'instant mais si plus tard dans le code on a besoin de changer le fonctionnement de Scene par expemple, alors ca serait plus simple à changer.
app/src/main/java/school_project/Controller.java
@@ -29,2 +35,3 @@
}
public static void main(String[] args) {
launch();
launch(args);
tonitch commented 2023-05-05 12:15:52 +02:00
Owner
Copy link
Copy source

pourquoi ?

pourquoi ?
tonitch marked this conversation as resolved
app/src/main/java/school_project/Menu/MenuAcceuil.java
@@ -0,0 +11,4 @@
private Button Play;
public static Button SelectLevel;
private Button Trophy;
private Label Title;
tonitch commented 2023-05-05 12:19:21 +02:00
Owner
Copy link
Copy source

Ces Variable (sauf selectlevel) peuvent

Ces Variable (sauf `selectlevel`) peuvent
tonitch marked this conversation as resolved
app/src/main/java/school_project/Menu/MenuAcceuil.java
@@ -0,0 +30,4 @@
setAlignment(Play,Pos.CENTER);
setAlignment(SelectLevel,Pos.CENTER);
setAlignment(Trophy,Pos.CENTER);
//Menu.getStylesheets().add("style.css"); todo creat a file css
tonitch commented 2023-05-05 12:21:50 +02:00
Owner
Copy link
Copy source

a enlever

a enlever
tonitch marked this conversation as resolved
app/src/main/java/school_project/Menu/MenuAcceuil.java
@@ -0,0 +34,4 @@
setPadding(new Insets(20,60,20,60));
SelectLevel.setOnAction(event -> Controller.switchRoot(new MenuLevel(1)));
getStyleClass().add("BorderPane");
getStylesheets().add(String.valueOf(getClass().getResource("StyleMenuAcceuil.css")));
tonitch commented 2023-05-05 12:21:06 +02:00
Owner
Copy link
Copy source

pour plus de lisibilitée quelques espaces seraient cool

pour plus de lisibilitée quelques espaces seraient cool
tonitch marked this conversation as resolved
app/src/main/java/school_project/Menu/MenuLevel.java
@@ -0,0 +13,4 @@
public Button[] Days = new Button[3];
public int StartLevel;
public ColumnConstraints[] Columns = new ColumnConstraints[3];
public RowConstraints[] Rows = new RowConstraints[5];
tonitch commented 2023-05-05 12:29:41 +02:00
Owner
Copy link
Copy source

Peuvent être locales

Peuvent être locales
tonitch marked this conversation as resolved
app/src/main/java/school_project/Menu/MenuLevel.java
@@ -0,0 +98,4 @@
tonitch commented 2023-05-05 12:24:02 +02:00
Owner
Copy link
Copy source

pourquoi y'a plein d'espaces

pourquoi y'a plein d'espaces
tonitch marked this conversation as resolved
Mat_02 added 1 commit 2023-05-06 21:46:08 +02:00
Correct all thing say expect the one about switchRoot I didn't understand (Btw add some comment)
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
a043cb487f
tonitch approved these changes 2023-05-07 10:46:09 +02:00
tonitch left a comment
Owner
Copy link
Copy source

juste le switchroot à voir si tu est d'accord ?

juste le switchroot à voir si tu est d'accord ?
Mat_02 added 1 commit 2023-05-09 12:56:42 +02:00
change the switchRoot method
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is passing
Details
af3489d078
tonitch added 1 commit 2023-05-09 13:10:06 +02:00
Merge branch 'menu'
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
24730a1362
tonitch approved these changes 2023-05-09 15:51:40 +02:00
Mat_02 merged commit a472df26ed into master 2023-05-09 15:52:14 +02:00
tonitch deleted branch menu 2023-05-09 15:53:51 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
tonitch
Labels
Clear labels
Important
Doit absolument être fait
 Moins important
Pas important
bug
Something is not working
 done
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 suppléments
à faire si on a le temps
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
BrokenBrad Mat_02 tonitch (Debucquoy Anthony)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: undefined_name/School_Project#43