undefined_name/School_Project
3
1
Fork 0
Code Issues 9 Pull Requests Projects 1 Releases 4 Wiki Activity

WIP : Brad_GraphPiece #25

Closed
BrokenBrad wants to merge 13 commits from Brad_GraphPiece into master
pull from: Brad_GraphPiece
merge into: undefined_name:master
Conversation 3 Commits 13 Files Changed 1 +213 -23
BrokenBrad commented 2023-03-27 01:36:04 +02:00
Member
Copy Link

been working on the events concerning the pieces and for the moment i have the rotation and the dragging . they're still are very rudimentary but it works tho .

been working on the events concerning the pieces and for the moment i have the rotation and the dragging . they're still are very rudimentary but it works tho .
BrokenBrad added 4 commits 2023-03-27 01:36:05 +02:00
WIP:piece graphics
All checks were successful
continuous-integration/drone/push Build is passing
Details
49d2c5d7ab
progress with the rotation system but still not finished , it works tho
All checks were successful
continuous-integration/drone/push Build is passing
Details
5911d88918
new progress , succeded in moving the node with the mouse still not
All checks were successful
continuous-integration/drone/push Build is passing
Details
895b20b680 
finished tho
new progress , succeded in moving the node with the mouse still not
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
bb5e2ff401 
finished tho
tonitch changed target branch from Shape_Piece_Map to master 2023-03-27 15:43:09 +02:00
tonitch commented 2023-03-27 15:48:52 +02:00
Owner
Copy Link

nice work,
but you put everything in a folder called piece/. the problem is that it is not int project structure and gradle will never build or use it in any way.

you should replace /app/src/main/java/school_project/Controller.java with your file and everything will be good ;)
@BrokenBrad

nice work, but you put everything in a folder called `piece/`. the problem is that it is not int project structure and gradle will never build or use it in any way. you should replace `/app/src/main/java/school_project/Controller.java` with your file and everything will be good ;) @BrokenBrad
tonitch added this to the Cats Organized Neatly project 2023-03-28 00:30:18 +02:00
Mat_02 approved these changes 2023-03-30 11:26:24 +02:00
Dismissed
Mat_02 left a comment
Member
Copy Link

lgtm

lgtm
BrokenBrad added 1 commit 2023-03-30 11:47:37 +02:00
progress
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
a99a53868b
BrokenBrad added 1 commit 2023-03-30 11:52:00 +02:00
progress
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
5bfb2aba9b
tonitch commented 2023-03-30 11:54:46 +02:00
Owner
Copy Link

nice work,
but you put everything in a folder called piece/. the problem is that it is not int project structure and gradle will never build or use it in any way.

you should replace /app/src/main/java/school_project/Controller.java with your file and everything will be good ;)
@BrokenBrad

up

> nice work, > but you put everything in a folder called `piece/`. the problem is that it is not int project structure and gradle will never build or use it in any way. > > you should replace `/app/src/main/java/school_project/Controller.java` with your file and everything will be good ;) > @BrokenBrad up
BrokenBrad added 1 commit 2023-03-30 23:58:13 +02:00
Ajouter 'app/src/main/java/school_project/Piece.java'
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is passing
Details
90f25b1c26
BrokenBrad added 1 commit 2023-03-30 23:58:55 +02:00
Supprimer 'app/src/main/java/school_project/Controller.java'
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
70fef807d5
BrokenBrad added 1 commit 2023-03-30 23:59:30 +02:00
Mise à jour de 'app/src/main/java/school_project/Controller.java'
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
fbbda476b4
BrokenBrad added 1 commit 2023-03-31 00:20:49 +02:00
Mise à jour de 'app/src/main/java/school_project/Controller.java'
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
d4f254139c
tonitch reviewed 2023-03-31 08:21:05 +02:00
app/src/main/java/school_project/Controller.java
@ -10,1 +17,4 @@
import javafx.animation.RotateTransition;
import javafx.stage.Stage;
import javafx.util.Duration;
public class Piece extends Application{
tonitch commented 2023-03-31 08:21:05 +02:00
Owner
Copy Link

Il faut que le nom de ta classe soit le nom du fichier.
Donc il faut public class Controller extends Application{

Il faut que le nom de ta classe soit le nom du fichier. Donc il faut `public class Controller extends Application{`
BrokenBrad added 1 commit 2023-04-04 15:20:43 +02:00
Mise à jour de 'app/src/main/java/school_project/Controller.java'
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
78e50549d0
tonitch added 1 commit 2023-04-06 18:15:40 +02:00
Fixing Branch
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
a6fc46a0ea
tonitch dismissed Mat_02’s review 2023-04-06 18:22:05 +02:00
Reason:

Not Finished

tonitch added 1 commit 2023-04-06 18:25:13 +02:00
fixup! Fixing Branch
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
37cc19f49a
tonitch commented 2023-05-12 11:05:20 +02:00
Owner
Copy Link

outdated

outdated
tonitch closed this pull request 2023-05-12 11:05:20 +02:00
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Important

Doit absolument être fait

  
Moins important

   
Pas important

   
bug

Something is not working

  
done

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
suppléments

à faire si on a le temps

  
wontfix

This won't be fixed

No Label
Important
Moins important
Pas important
bug
done
duplicate
enhancement
help wanted
invalid
question
suppléments
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Cats Organized Neatly
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: undefined_name/School_Project#25
No description provided.
Delete Branch "Brad_GraphPiece"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?