PGL/Clyde
PGL/Clyde
3
2
Fork 3
Code Issues 13 Pull Requests Actions Projects 3 Releases 2 Wiki Activity

Leo/Backend #95

Merged
tonitch merged 6 commits from Leo/Backend into master 2024-03-13 18:06:35 +01:00
Conversation 1 Commits 6 Files Changed 6 +29 -18
LeoMoulin commented 2024-03-12 10:50:14 +01:00
Owner
Copy Link

Ajoute le flag false par défaut dans réinscription request.
Implémente la méthode de suppression de fichiers (et de l'entité qui y est liée dans la db)

Ajoute le flag false par défaut dans réinscription request. Implémente la méthode de suppression de fichiers (et de l'entité qui y est liée dans la db)
LeoMoulin added 2 commits 2024-03-12 10:50:15 +01:00 
Add user/inscriptionrequest connection to StorageFile entity.
Create a prototype of the delete for file function
Remove the bad link between users and file. Add a delete function for storageFile entities and clean things.
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m0s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m57s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
8fbfb36958
LeoMoulin added 1 commit 2024-03-12 11:17:18 +01:00
Merge branch 'master' into Leo/Backend
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m57s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m55s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 23s
Details
b7a574a312
LeoMoulin requested review from Owners 2024-03-12 11:17:44 +01:00
LeoMoulin removed review request for Owners 2024-03-12 11:17:52 +01:00
LeoMoulin requested review from tonitch 2024-03-12 11:17:57 +01:00
LeoMoulin requested review from Maxime 2024-03-12 11:17:58 +01:00
LeoMoulin requested review from Wal 2024-03-12 11:17:58 +01:00
LeoMoulin changed title from Leo/Backend to WIP: Leo/Backend 2024-03-12 17:52:18 +01:00
LeoMoulin added 1 commit 2024-03-12 17:54:16 +01:00
Create new constructor for ReinscriptionRequest so you don't have to worry about the type of the request
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m15s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m59s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
66282bce9f
LeoMoulin commented 2024-03-12 17:56:28 +01:00
Author
Owner
Copy Link

J'ai ajouté un constructeur dans ReinscriptionRequest qui ne prend pas de type de requête comme ca vous n'avez pas a vous en préoccuper (c'est moi qui me servirai du type plus tard dans mon extension)

J'ai ajouté un constructeur dans ReinscriptionRequest qui ne prend pas de type de requête comme ca vous n'avez pas a vous en préoccuper (c'est moi qui me servirai du type plus tard dans mon extension)
LeoMoulin changed title from WIP: Leo/Backend to Leo/Backend 2024-03-12 17:56:42 +01:00
Maxime approved these changes 2024-03-12 22:07:06 +01:00
Maxime left a comment
Owner
Copy Link

par pitié nome ta branche avec {nom}/{side}/{ce sur quoi tu bosse}

image

par pitié nome ta branche avec {nom}/{side}/{ce sur quoi tu bosse} ![image](/attachments/d1646e52-f553-41a7-9a9b-8b557e20bbcb)
image.png
27 KiB
😆 1
Wal approved these changes 2024-03-13 13:54:07 +01:00
tonitch approved these changes 2024-03-13 14:09:29 +01:00
tonitch left a comment
Owner
Copy Link

Ca me semble bien, j'approuve parce que c'est bon mais j'avoue que l'exception me semble un peu bizzare

Ca me semble bien, j'approuve parce que c'est bon mais j'avoue que l'exception me semble un peu bizzare
backend/src/main/java/ovh/herisson/Clyde/Services/StorageService.java Outdated
@ -56,0 +61,4 @@
File f = new File(file.getUrl());
//Delete le fichier
try{
f.delete();
tonitch commented 2024-03-13 14:06:38 +01:00
Owner
Copy Link

f.delete peut throw uniquement : SecurityException et je trouve (personnellement) que c'est assez clair comme ça. dire qu'il y a une érreur de permissions est plus clair que dire "j'ai pas réussi à supprimer lol" ^^

f.delete peut throw uniquement : [`SecurityException`](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/File.html#delete()) et je trouve (personnellement) que c'est assez clair comme ça. dire qu'il y a une érreur de permissions est plus clair que dire "j'ai pas réussi à supprimer lol" ^^
tonitch marked this conversation as resolved
LeoMoulin added 1 commit 2024-03-13 15:48:36 +01:00
Apply les trucs de l'exception
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m1s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m55s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 25s
Details
2a58c335f2
tonitch added 1 commit 2024-03-13 18:05:38 +01:00
fixing the double throw before the merge
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m3s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m57s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
5c7147bb17 
Signed-off-by: Debucquoy Anthony <d.tonitch@gmail.com>
tonitch merged commit cead1188ab into master 2024-03-13 18:06:35 +01:00
tonitch deleted branch Leo/Backend 2024-03-13 18:06:35 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Maxime
Wal
tonitch
Labels
Clear labels   
Bug

   
Done

finie, en attente de validation pour ou pret à la fermeture

  
Pas urgent

A faire que si on a le temps

  
Proposition

   
Question

   
TODO

   
Tests

   
URGENT BORDEL DE Q

   
Waiting for review

   
back

   
front
No Label
Bug
Done
Pas urgent
Proposition
Question
TODO
Tests
URGENT BORDEL DE Q
Waiting for review
back
front
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PGL/Clyde#95
No description provided.
Delete Branch "Leo/Backend"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?