Register API and form optimization [depend: backend /register] #93

Merged
tonitch merged 2 commits from tonitch/front/register into master 2024-03-15 14:46:40 +01:00
Owner

Made the register api following the backend

refactored the register form for more ergonomy

PS: Waiting for the backend to catch up

Made the register api following the backend refactored the register form for more ergonomy **PS: Waiting for the backend to catch up**
tonitch added 1 commit 2024-03-10 23:31:23 +01:00
Register API and form optimization
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m59s
Build and test backend / Test-backend (pull_request) Successful in 1m57s
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
485316c576
Made the register api following the backend

refactored the register form for more ergonomy
tonitch added the
front
label 2024-03-10 23:31:37 +01:00
tonitch changed title from Register API and form optimization to Register API and form optimization [depend: backend /register] 2024-03-10 23:32:32 +01:00
Maxime requested changes 2024-03-12 23:24:19 +01:00
Maxime left a comment
Owner

image

(FAUX)

![image](/attachments/202a3805-1856-4dee-8009-0903de1312d6) (FAUX)
@ -9,0 +18,4 @@
* - country
* - cursus
*/
export async function register(firstname, lastname, birthDate, password, email, address, country, cursus){
Owner

ProfilePictureUrl pas présent ?

ProfilePictureUrl pas présent ?
Owner

car de mémoire tu postais l'image directe je te retournais l'URL comme ça tu la postais

car de mémoire tu postais l'image directe je te retournais l'URL comme ça tu la postais
Author
Owner

c'est parce que j'avais fait ça avant qu'on parle des pp 👉👈

c'est parce que j'avais fait ça avant qu'on parle des pp 👉👈
Author
Owner

@Maxime Le problème c'est que si tu me retourne l'url tu vas pas pouvoir le lier à la db
faudrait du coup me retourner l'id que je te retourne. Ce qui n'est pas ouf non plus mais bon. en vrai autant ne pas trop se casser la tête

@Maxime Le problème c'est que si tu me retourne l'url tu vas pas pouvoir le lier à la db faudrait du coup me retourner l'id que je te retourne. Ce qui n'est pas ouf non plus mais bon. en vrai autant ne pas trop se casser la tête
Maxime marked this conversation as resolved
@ -9,0 +48,4 @@
* PS: the password is not is not required as it is generated by the backend and sent to the user
* by mail. it's up to the user to change it if he cares about security
*/
export async function createUser(firstname, lastname, birthDate, email, address, country, cursus, role){
Owner

pas necessairement de cursus, surtout dans le cadre où le secrétariat postent les teachers

(surtout que les users on pas de cursus)

pas necessairement de cursus, surtout dans le cadre où le secrétariat postent les teachers (surtout que les users on pas de cursus)
@ -9,0 +49,4 @@
* by mail. it's up to the user to change it if he cares about security
*/
export async function createUser(firstname, lastname, birthDate, email, address, country, cursus, role){
return restPost("/user", {
Owner
same that https://git.herisson.ovh/PGL/Clyde/pulls/93/files#issuecomment-1637
tonitch requested review from Maxime 2024-03-13 13:18:39 +01:00
Maxime approved these changes 2024-03-14 22:04:46 +01:00
Maxime left a comment
Owner
https://www.google.com/url?sa=i&url=https%3A%2F%2Fgithub.com%2Fshuuuuun%2Fsandbox%2Fissues%2F1&psig=AOvVaw1KKjIIdbBPyWqRArTCGj_s&ust=1710536670356000&source=images&cd=vfe&opi=89978449&ved=0CBMQjRxqFwoTCPj1qOfT9IQDFQAAAAAdAAAAABAI
Wal approved these changes 2024-03-14 22:47:20 +01:00
LeoMoulin approved these changes 2024-03-14 22:56:21 +01:00
tonitch force-pushed tonitch/front/register from f4e24fe6c7 to e6dd0a8995 2024-03-15 14:46:21 +01:00 Compare
tonitch merged commit 198ee8a4ce into master 2024-03-15 14:46:40 +01:00
tonitch deleted branch tonitch/front/register 2024-03-15 14:46:40 +01:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PGL/Clyde#93
No description provided.