PGL/Clyde
PGL/Clyde
3
2
Fork 3
Code Issues 13 Pull Requests Actions Projects 3 Releases 2 Wiki Activity

Lots of refactoring #75

Merged
tonitch merged 1 commits from tonitch/front/refactoring/ApplicationsPaterned into master 2024-03-09 09:52:56 +01:00
Conversation 5 Commits 1 Files Changed 10 +25 -144
tonitch commented 2024-03-08 23:35:01 +01:00
Owner
Copy Link
  • Removing test mentions in readme
  • moving login page as an app
  • removing vite broken config
  • removing auto-generated and unused vite configuration (base.css)

Overall simplification

(sorry @Wal I kinda destroyed your login page a bit but seems fixable 👉👈)

- Removing test mentions in readme - moving login page as an app - removing vite broken config - removing auto-generated and unused vite configuration (base.css) Overall simplification (sorry @Wal I kinda destroyed your login page a bit but seems fixable 👉👈)
tonitch added 1 commit 2024-03-08 23:35:01 +01:00
Lots of refactoring
Some checks failed
Build and test backend / Build-backend (pull_request) Successful in 2m3s
Details
Build and test backend / Test-backend (pull_request) Successful in 2m1s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 26s
Details
Build and test FrontEnd / Build-frontend (push) Waiting to run
Details
Build and test backend / Build-backend (push) Successful in 2m13s
Details
Build and test backend / Test-backend (push) Successful in 1m18s
Details
deploy to production / deploy-frontend (push) Successful in 25s
Details
deploy to production / deploy-backend (push) Has been cancelled
Details
ba8b32160d 
- Removing test mentions in readme
- moving login page as an app
- removing vite broken config
- removing auto-generated and unused vite configuration (base.css)

Overall simplification

(sorry @Wal I kinda destroyed your login page a bit but seems fixable 👉👈)
Wal commented 2024-03-08 23:36:21 +01:00
Owner
Copy Link
  • Removing test mentions in readme
  • moving login page as an app
  • removing vite broken config
  • removing auto-generated and unused vite configuration (base.css)

Overall simplification

(sorry @Wal I kinda destroyed your login page a bit but seems fixable 👉👈)

J'y avais deja pensé et normalement en supprimant le centerer ca devrait bien marcher
Si pas pg je tafferai dessus demain

> - Removing test mentions in readme > - moving login page as an app > - removing vite broken config > - removing auto-generated and unused vite configuration (base.css) > > Overall simplification > > (sorry @Wal I kinda destroyed your login page a bit but seems fixable 👉👈) J'y avais deja pensé et normalement en supprimant le centerer ca devrait bien marcher Si pas pg je tafferai dessus demain
tonitch commented 2024-03-08 23:36:26 +01:00
Author
Owner
Copy Link

Fixes: #73
Fixes: #74

Fixes: #73 Fixes: #74
Wal approved these changes 2024-03-08 23:47:48 +01:00
Wal left a comment
Owner
Copy Link

Jai verif et pour le login cest très facile à remettre correctement(bon ce sera un peu plus haut en vertical mais is ok cest pas la mort )

Jai verif et pour le login cest très facile à remettre correctement(bon ce sera un peu plus haut en vertical mais is ok cest pas la mort )
❤️ 1
tonitch commented 2024-03-08 23:49:35 +01:00
Author
Owner
Copy Link

Jai verif et pour le login cest très facile à remettre correctement(bon ce sera un peu plus haut en vertical mais is ok cest pas la mort )

J'ai juste remarqué que le shadow pète un cable mais pour la position non en effet ça à l'air "trivial" comme dirait Troestler

> Jai verif et pour le login cest très facile à remettre correctement(bon ce sera un peu plus haut en vertical mais is ok cest pas la mort ) J'ai juste remarqué que le shadow pète un cable mais pour la position non en effet ça à l'air "trivial" comme dirait **Troestler**
Maxime approved these changes 2024-03-08 23:50:44 +01:00
tonitch merged commit ba8b32160d into master 2024-03-09 09:52:56 +01:00
tonitch deleted branch tonitch/front/refactoring/ApplicationsPaterned 2024-03-09 09:52:56 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Wal
Maxime
Labels
Clear labels
Bug
Done
finie, en attente de validation pour ou pret à la fermeture
Pas urgent
A faire que si on a le temps
Proposition
Question
TODO
Tests
URGENT BORDEL DE Q
Waiting for review
back
front
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PGL/Clyde#75
No description provided.
Delete Branch "tonitch/front/refactoring/ApplicationsPaterned"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?