PGL/Clyde
PGL/Clyde
3
2
Fork 3
Code Issues 13 Pull Requests Actions Projects 3 Releases 2 Wiki Activity

fixed a token encoding issue #70

Merged
tonitch merged 3 commits from Max/backend/loginFix into master 2024-03-09 09:57:54 +01:00
Conversation 1 Commits 3 Files Changed 2 +31 -9
Maxime commented 2024-03-08 18:55:22 +01:00
Owner
Copy Link
No description provided.
Maxime added the
Done
Waiting for review
 labels 2024-03-08 18:55:22 +01:00
Maxime added 1 commit 2024-03-08 18:55:23 +01:00
fixed a token encoding issue
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m33s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m59s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 23s
Details
fba30cff9e
tonitch approved these changes 2024-03-08 20:54:21 +01:00
Dismissed
tonitch left a comment
Owner
Copy Link

image

![image](/attachments/63e75cbb-6751-4c6e-9c17-a25e7b2fdac4)
image.png
150 KiB
backend/src/main/java/ovh/herisson/Clyde/EndPoints/LoginController.java Outdated
@ -25,3 +23,1 @@
HttpHeaders responseHeaders = new HttpHeaders();
responseHeaders.set("Set-Cookie",String.format("session_token=%s",sessionToken));
return ResponseEntity.ok().headers(responseHeaders).build();
return ResponseEntity.ok().header("Set-Cookie", String.format("session_token=%s", sessionToken)).build();
tonitch commented 2024-03-08 20:51:17 +01:00
Owner
Copy Link

resembler pour mieux brainfuck ^^

resembler pour mieux brainfuck ^^
Maxime commented 2024-03-08 20:56:59 +01:00
Author
Owner
Copy Link

osef

osef
Maxime marked this conversation as resolved
backend/src/main/java/ovh/herisson/Clyde/Services/TokenService.java
@ -22,9 +24,12 @@ public class TokenService {
public String generateNewToken(){
byte[] bytes = new byte[64];
new SecureRandom().nextBytes(bytes);
tonitch commented 2024-03-08 20:53:57 +01:00
Owner
Copy Link

je suis un peu curieux de la différence avec Random()

je suis un peu curieux de la différence avec Random()
Maxime commented 2024-03-08 20:58:06 +01:00
Author
Owner
Copy Link

random est moins random et plus prévisible donc plus de conflits (on m'a juste conseillé SecureRandom donc sur un site donc voila
)

random est moins random et plus prévisible donc plus de conflits (on m'a juste conseillé SecureRandom donc sur un site donc voila )
Maxime marked this conversation as resolved
Maxime added 1 commit 2024-03-08 20:55:26 +01:00
put the params in the body and fixed token issue
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m0s
Details
Build and test backend / Test-backend (pull_request) Successful in 2m0s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 20s
Details
82a3b152f2
Maxime dismissed tonitch’s review 2024-03-08 20:55:26 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Maxime commented 2024-03-08 20:56:42 +01:00
Author
Owner
Copy Link

Exemple de Json pour le body du POST /login
{
"identifier": "1",
"password": "admin",
"expirationDate": "2024-03-08T22:34:33"
}

Exemple de Json pour le body du POST /login { "identifier": "1", "password": "admin", "expirationDate": "2024-03-08T22:34:33" }
tonitch reviewed 2024-03-08 21:00:56 +01:00
backend/src/main/java/ovh/herisson/Clyde/Services/TokenService.java Outdated
@ -28,0 +30,4 @@
new SecureRandom().nextBytes(temp);
bytes[i] = temp[0];
}
}
tonitch commented 2024-03-08 21:00:56 +01:00
Owner
Copy Link

tu viens pas de dupliquer le new SecureRandom().nextBytes(bytes); ?

tu viens pas de dupliquer le `new SecureRandom().nextBytes(bytes);` ?
tonitch commented 2024-03-08 21:02:23 +01:00
Owner
Copy Link

https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/security/SecureRandom.html

https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/security/SecureRandom.html
tonitch marked this conversation as resolved
tonitch reviewed 2024-03-08 21:14:51 +01:00
backend/src/main/java/ovh/herisson/Clyde/Services/TokenService.java Outdated
@ -26,2 +27,2 @@
System.out.println(token);
return token;
for (int i = 0; i < bytes.length; i++) {
while (bytes[i] == 0){
tonitch commented 2024-03-08 21:14:51 +01:00
Owner
Copy Link

tu peux aussi ( x / 4 (division entière) + 64) et ainsi tu est dans une range affichable (lazy)

tu peux aussi ( x / 4 (division entière) + 64) et ainsi tu est dans une range affichable (lazy)
Maxime commented 2024-03-08 23:51:38 +01:00
Author
Owner
Copy Link

smart je vais try

smart je vais try
Maxime added 1 commit 2024-03-09 00:47:18 +01:00
token is now an writable char thanks to the modulos !
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m3s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m57s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 22s
Details
521c98fdc2
Maxime reviewed 2024-03-09 09:38:32 +01:00
backend/src/main/java/ovh/herisson/Clyde/Services/TokenService.java
@ -26,2 +27,2 @@
System.out.println(token);
return token;
for (int i = 0; i < bytes.length; i++) {
bytes[i] = (byte) (((bytes[i]+256)%256 %95+ 32));
Maxime commented 2024-03-09 09:38:32 +01:00
Author
Owner
Copy Link

Permet d'avoir des caractères affichable

Permet d'avoir des caractères affichable
Wal approved these changes 2024-03-09 09:38:42 +01:00
tonitch approved these changes 2024-03-09 09:39:38 +01:00
tonitch left a comment
Owner
Copy Link

image

![image](/attachments/8159faf3-28bf-4184-8578-ef7606f9c8c5)
image.png
299 KiB
LeoMoulin approved these changes 2024-03-09 09:57:25 +01:00
tonitch merged commit b88d820c12 into master 2024-03-09 09:57:54 +01:00
tonitch deleted branch Max/backend/loginFix 2024-03-09 09:57:54 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Wal
tonitch
LeoMoulin
Labels
Clear labels   
Bug

   
Done

finie, en attente de validation pour ou pret à la fermeture

  
Pas urgent

A faire que si on a le temps

  
Proposition

   
Question

   
TODO

   
Tests

   
URGENT BORDEL DE Q

   
Waiting for review

   
back

   
front
No Label
Bug
Done
Pas urgent
Proposition
Question
TODO
Tests
URGENT BORDEL DE Q
Waiting for review
back
front
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PGL/Clyde#70
No description provided.
Delete Branch "Max/backend/loginFix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?