PGL/Clyde
PGL/Clyde
3
2
Fork 3
Code Issues 13 Pull Requests Actions Projects 3 Releases 2 Wiki Activity

Max/Backend/loginApi Ajout mock Users et Tokens #62

Merged
Maxime merged 16 commits from Max/Backend/loginApi into master 2024-03-08 16:50:23 +01:00
Conversation 2 Commits 16 Files Changed 18 +334 -73
Maxime commented 2024-03-07 00:59:35 +01:00
Owner
Copy Link

J'ai tapé ça vite checkez avec attention mais normalement y'a de quoi faire des petits tests

J'ai tapé ça vite checkez avec attention mais normalement y'a de quoi faire des petits tests
Maxime added 8 commits 2024-03-07 00:59:36 +01:00
added mocks users with their role as password and token
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m58s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m58s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 21s
Details
2938707f0f
Maxime commented 2024-03-07 00:59:46 +01:00
Author
Owner
Copy Link

dodo mtn

dodo mtn
tonitch changed title from Max/Backend/loginApi to Max/Backend/loginApi (MAX FAUT NAME TES PR x) 2024-03-07 08:07:20 +01:00
tonitch approved these changes 2024-03-07 09:41:05 +01:00
Dismissed
tonitch left a comment
Owner
Copy Link

faut dormir monsieur...

faut dormir monsieur...
backend/src/main/java/ovh/herisson/Clyde/EndPoints/LoginController.java
@ -0,0 +25,4 @@
User user = userService.getUser(identifier);
if (user == null){
return new ResponseEntity<String>("wrong ID or Email", HttpStatus.BAD_REQUEST);
tonitch commented 2024-03-07 08:38:12 +01:00
Owner
Copy Link

en vrai c'est un choix mais souvent il ne vaut mieux pas dire si le truc qui va pas c'est l'id ou le pass parce que avec ça tu peux savoir si qqun est inscrit sur le site ou non (ce qui n'est pas toujours souhaitable)
En gros si l'un des deux est mauvais tu retourne erreur d'authentication et puis basta x)

Mais certains sites font comme t'a fait donc c'est juste un choix. les deux sont bon pour moi

en vrai c'est un choix mais souvent il ne vaut mieux pas dire si le truc qui va pas c'est l'id ou le pass parce que avec ça tu peux savoir si qqun est inscrit sur le site ou non (ce qui n'est pas toujours souhaitable) En gros si l'un des deux est mauvais tu retourne erreur d'authentication et puis basta x) Mais certains sites font comme t'a fait donc c'est juste un choix. les deux sont bon pour moi
Maxime marked this conversation as resolved
backend/src/main/java/ovh/herisson/Clyde/EndPoints/UserController.java
@ -13,30 +16,36 @@ import ovh.herisson.Clyde.Tables.User;
@CrossOrigin(origins = "http://localhost:5173")
tonitch commented 2024-03-07 08:59:54 +01:00
Owner
Copy Link

il ne faut pas un @RestController ?

il ne faut pas un @RestController ?
Maxime commented 2024-03-07 10:29:41 +01:00
Author
Owner
Copy Link

si

si
Maxime marked this conversation as resolved
backend/src/main/java/ovh/herisson/Clyde/EndPoints/UserController.java Outdated
@ -19,1 +21,3 @@
this.userRepo = userRepo;
private final TokenService tokenService;
public UserController(UserService userService, TokenService tokenService){
this.userService =userService;
tonitch commented 2024-03-07 09:13:44 +01:00
Owner
Copy Link

l’espace après le =
s'il
te
plait
...

l’espace après le = s'il te plait ...
Maxime marked this conversation as resolved
Maxime changed title from Max/Backend/loginApi (MAX FAUT NAME TES PR x) to Max/Backend/loginApi Ajout mock Users et Tokens 2024-03-07 10:28:57 +01:00
Maxime added 1 commit 2024-03-07 15:15:48 +01:00
Merge branch 'master' into Max/Backend/loginApi
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m1s
Details
Build and test backend / Test-backend (pull_request) Successful in 2m1s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 20s
Details
e1d8e37c52
Maxime dismissed tonitch’s review 2024-03-07 15:15:48 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Maxime changed title from Max/Backend/loginApi Ajout mock Users et Tokens to WIP: Max/Backend/loginApi Ajout mock Users et Tokens 2024-03-07 15:18:15 +01:00
Maxime added 2 commits 2024-03-07 17:02:42 +01:00
cleaning
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m57s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m56s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 21s
Details
6b58c852a2
Maxime added 1 commit 2024-03-07 17:31:08 +01:00
added the possibility to remove the mocks
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m6s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m58s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 21s
Details
2f2a72bfa0
LeoMoulin added 3 commits 2024-03-07 20:53:36 +01:00 
- Ajout des relation
Merge branch 'Leo/Backend' into Max/Backend/loginApi
Some checks failed
Build and test backend / Build-backend (pull_request) Failing after 1m36s
Details
Build and test backend / Test-backend (pull_request) Failing after 1m35s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 20s
Details
3b31fa794f
tonitch commented 2024-03-08 11:38:50 +01:00
Owner
Copy Link

Le problème est que vous ne fournisiez pas la profile picture dans le constructeur de user.

Vous pouvez par example mettre une image dans resources/static et si la profile picture n'est pas spécifiée, par défault il redirige vers cette profile picture et ainsi il y a une image par defaut

Le problème est que vous ne fournisiez pas la profile picture dans le constructeur de user. Vous pouvez par example mettre une image dans resources/static et si la profile picture n'est pas spécifiée, par défault il redirige vers cette profile picture et ainsi il y a une image par defaut
Maxime added 1 commit 2024-03-08 12:01:20 +01:00
fixed the user constructor issue
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m3s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m58s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 20s
Details
acfd366fc8
Maxime changed title from WIP: Max/Backend/loginApi Ajout mock Users et Tokens to Max/Backend/loginApi Ajout mock Users et Tokens 2024-03-08 14:00:30 +01:00
Maxime added the
Done
Waiting for review
 labels 2024-03-08 14:02:00 +01:00
tonitch approved these changes 2024-03-08 14:09:10 +01:00
Wal approved these changes 2024-03-08 14:11:40 +01:00
LeoMoulin approved these changes 2024-03-08 15:06:39 +01:00
Maxime merged commit 875cfb8b7c into master 2024-03-08 16:50:23 +01:00
Maxime deleted branch Max/Backend/loginApi 2024-03-08 16:50:23 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tonitch
Wal
LeoMoulin
Labels
Clear labels   
Bug

   
Done

finie, en attente de validation pour ou pret à la fermeture

  
Pas urgent

A faire que si on a le temps

  
Proposition

   
Question

   
TODO

   
Tests

   
URGENT BORDEL DE Q

   
Waiting for review

   
back

   
front
No Label
Bug
Done
Pas urgent
Proposition
Question
TODO
Tests
URGENT BORDEL DE Q
Waiting for review
back
front
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PGL/Clyde#62
No description provided.
Delete Branch "Max/Backend/loginApi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?