PGL/Clyde
PGL/Clyde
3
2
Fork 3
Code Issues 13 Pull Requests Actions Projects 3 Releases 2 Wiki Activity

Ext_publiScientifique #5

Merged
Maxime merged 7 commits from Ext_publiScientifique into master 2023-12-13 15:37:50 +01:00
Conversation 0 Commits 7 Files Changed 1 +250 -15
Maxime commented 2023-12-11 10:33:44 +01:00
Owner
Copy Link

pull request from the ext scientifique articles

pull request from the ext scientifique articles
Maxime added 2 commits 2023-12-11 10:33:45 +01:00 
ajout endpoint dans : secretariat, users, researcher
ajout schemas : article
Maxime added 1 commit 2023-12-11 10:45:54 +01:00
LeoMoulin approved these changes 2023-12-11 10:48:51 +01:00
Maxime added 1 commit 2023-12-11 11:28:08 +01:00
Maxime reviewed 2023-12-11 23:28:22 +01:00
Maxime left a comment
Author
Owner
Copy Link

t'es un bogosse ultime mais il manque l'envoi de pdf

t'es un bogosse ultime mais il manque l'envoi de pdf
Documents/proto/general/openapi.yaml Outdated
@ -368,0 +410,4 @@
type: string
description: Follow the iso 8601 ("YYYY-MM-DD")
views:
type: integer #TODO check comment envoyer fichier + json
Maxime commented 2023-12-11 23:28:02 +01:00
Author
Owner
Copy Link

changer pour le pdf dans B64 trou du cul va

changer pour le pdf dans B64 trou du cul va
👀 1
Maxime added 1 commit 2023-12-12 14:37:12 +01:00 
(et Mat -> RegNo)
tonitch reviewed 2023-12-12 22:58:51 +01:00
Documents/proto/general/openapi.yaml Outdated
@ -369,0 +507,4 @@
'401':
$ref: '#/components/responses/UnauthorizedError'
/Display-Article:
tonitch commented 2023-12-12 22:58:51 +01:00
Owner
Copy Link

c'est pas très grave mais ça me parait weird d'avoir un endpoint avec un tired. j'utiliserait personnelment du PascalCase /DisplayArticle ou camelCase /displayArticle

c'est pas très grave mais ça me parait weird d'avoir un endpoint avec un tired. j'utiliserait personnelment du PascalCase `/DisplayArticle` ou camelCase `/displayArticle`
tonitch approved these changes 2023-12-12 22:59:15 +01:00
tonitch left a comment
Owner
Copy Link

lgtm

lgtm
Maxime added 1 commit 2023-12-13 14:41:44 +01:00
Maxime added 1 commit 2023-12-13 15:35:47 +01:00
Wal approved these changes 2023-12-13 15:36:57 +01:00
Maxime merged commit 351c0dbfb2 into master 2023-12-13 15:37:50 +01:00
tonitch deleted branch Ext_publiScientifique 2023-12-13 17:00:12 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
LeoMoulin
tonitch
Wal
Labels
Clear labels   
Bug

   
Done

finie, en attente de validation pour ou pret à la fermeture

  
Pas urgent

A faire que si on a le temps

  
Proposition

   
Question

   
TODO

   
Tests

   
URGENT BORDEL DE Q

   
Waiting for review

   
back

   
front
No Label
Bug
Done
Pas urgent
Proposition
Question
TODO
Tests
URGENT BORDEL DE Q
Waiting for review
back
front
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PGL/Clyde#5
No description provided.
Delete Branch "Ext_publiScientifique"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?