PGL/Clyde
PGL/Clyde
3
2
Fork 3
Code Issues 13 Pull Requests Actions Projects 3 Releases 2 Wiki Activity

Leo/Backend/UnitTest #138

Merged
LeoMoulin merged 17 commits from Leo/Backend/UnitTest into master 2024-03-18 19:21:55 +01:00
Conversation 3 Commits 17 Files Changed 15 +497 -18
LeoMoulin commented 2024-03-17 10:35:52 +01:00
Owner
Copy Link

Première salve de tests

Première salve de tests
LeoMoulin added 2 commits 2024-03-17 10:35:53 +01:00
Add tests for Storage system
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m53s
Details
Build and test backend / Test-backend (pull_request) Successful in 2m17s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 25s
Details
189e664f37
LeoMoulin added 1 commit 2024-03-17 10:36:04 +01:00
Merge branch 'master' into Leo/Backend/UnitTest
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m17s
Details
Build and test backend / Test-backend (pull_request) Successful in 2m17s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
008af10d0e
LeoMoulin requested review from Maxime 2024-03-17 10:36:29 +01:00
LeoMoulin requested review from Wal 2024-03-17 10:36:30 +01:00
LeoMoulin requested review from tonitch 2024-03-17 10:36:33 +01:00
Maxime approved these changes 2024-03-17 13:20:06 +01:00
Maxime left a comment
Owner
Copy Link

ça manque méchament de tests sur les controllers sachant que c'est ce qui fait toute l'api mais à par ça c'est good

ça manque méchament de tests sur les controllers sachant que c'est ce qui fait toute l'api mais à par ça c'est good
backend/src/test/java/ovh/herisson/Clyde/Services/StorageServiceTest.java
@ -0,0 +30,4 @@
@Autowired
FileRepository fileRepo;
StorageService ss;
Maxime commented 2024-03-17 13:14:17 +01:00
Owner
Copy Link

normalement tu peux aussi @ Autowired le StorageService

normalement tu peux aussi @ Autowired le StorageService
LeoMoulin commented 2024-03-17 19:21:19 +01:00
Author
Owner
Copy Link

Edit : j'ai testé et ca fait crash les tests

Edit : j'ai testé et ca fait crash les tests
Maxime marked this conversation as resolved
LeoMoulin added 3 commits 2024-03-17 15:42:50 +01:00 
# Conflicts:
#	backend/src/main/java/ovh/herisson/Clyde/EndPoints/UserController.java
Add tests for UserController get and post
Some checks failed
Build and test backend / Build-backend (pull_request) Failing after 2m22s
Details
Build and test backend / Test-backend (pull_request) Failing after 2m24s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
37a9eb46ae
LeoMoulin added 1 commit 2024-03-17 15:54:08 +01:00
Add test for user patch
Some checks failed
Build and test backend / Build-backend (pull_request) Failing after 2m24s
Details
Build and test backend / Test-backend (pull_request) Failing after 2m22s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
571d27c230
LeoMoulin commented 2024-03-17 15:55:32 +01:00
Author
Owner
Copy Link

ça manque méchament de tests sur les controllers sachant que c'est ce qui fait toute l'api mais à par ça c'est good

tkt ca vient

> ça manque méchament de tests sur les controllers sachant que c'est ce qui fait toute l'api mais à par ça c'est good tkt ca vient
LeoMoulin added 1 commit 2024-03-17 19:06:35 +01:00
Add testing for file uploading and correct minors bugs in service
Some checks failed
Build and test backend / Build-backend (pull_request) Failing after 3m14s
Details
Build and test backend / Test-backend (pull_request) Failing after 2m30s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 26s
Details
924faca13f
LeoMoulin added 2 commits 2024-03-17 19:17:56 +01:00 
# Conflicts:
#	backend/src/main/java/ovh/herisson/Clyde/EndPoints/UserController.java
Resolve conflicts and resolve condition bug in isNotSecretaryOrAdmin
Some checks failed
Build and test backend / Build-backend (pull_request) Failing after 2m27s
Details
Build and test backend / Test-backend (pull_request) Failing after 2m25s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
f2b80ba89f
LeoMoulin requested review from Maxime 2024-03-17 19:18:32 +01:00
tonitch added 1 commit 2024-03-17 22:02:52 +01:00
Fixing the CI
Some checks failed
Build and test backend / Build-backend (pull_request) Failing after 2m45s
Details
Build and test backend / Test-backend (pull_request) Failing after 2m37s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
ee37dc79a7 
Moving the dev test and build to port 5442 from 5432 to avoid
conflicting with the running postgresql
tonitch added 1 commit 2024-03-17 22:40:33 +01:00
CI -> build no test and trying to fix test
Some checks failed
Build and test backend / Build-backend (pull_request) Successful in 1m50s
Details
Build and test backend / Test-backend (pull_request) Failing after 2m38s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 26s
Details
611e7167f9
tonitch added 1 commit 2024-03-18 02:14:45 +01:00
Small improvement
Some checks failed
Build and test backend / Build-backend (pull_request) Successful in 1m45s
Details
Build and test backend / Test-backend (pull_request) Failing after 3m25s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 25s
Details
853a3a42d2
tonitch added 1 commit 2024-03-18 12:41:26 +01:00
disable test on ci, problem for later
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m42s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
d40ceff2ba
tonitch commented 2024-03-18 13:10:16 +01:00
Owner
Copy Link

@LeoMoulin j'ai enlevé les test sur ci pour l'instant, je les réglerais plus tard

@LeoMoulin j'ai enlevé les test sur ci pour l'instant, je les réglerais plus tard
LeoMoulin commented 2024-03-18 13:51:49 +01:00
Author
Owner
Copy Link

Alz je peux merge dcp ?

Alz je peux merge dcp ?
tonitch approved these changes 2024-03-18 13:52:39 +01:00
LeoMoulin added 2 commits 2024-03-18 14:29:42 +01:00 
# Conflicts:
#	backend/src/main/java/ovh/herisson/Clyde/Services/AuthenticatorService.java
#	backend/src/main/java/ovh/herisson/Clyde/Services/UserService.java
Resolve conflicts and adapt tests
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m49s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 25s
Details
9744bd973f
tonitch approved these changes 2024-03-18 14:50:29 +01:00
Maxime approved these changes 2024-03-18 14:58:15 +01:00
Maxime left a comment
Owner
Copy Link

image

![image](/attachments/d2ce1641-8406-4744-bbc4-11c2b8b85624)
image.png
1.5 MiB
backend/src/main/java/ovh/herisson/Clyde/Repositories/FileRepository.java Outdated
@ -8,1 +11,4 @@
public interface FileRepository extends CrudRepository<StorageFile,Long> {
public StorageFile getStorageFileByName(String name);
@Query("select s from StorageFile s")
Maxime commented 2024-03-18 14:50:39 +01:00
Owner
Copy Link

pas besoin c'est déjà implémenté de base

pas besoin c'est déjà implémenté de base
LeoMoulin commented 2024-03-18 15:56:24 +01:00
Author
Owner
Copy Link

bien vu c'est delete

bien vu c'est delete
backend/src/test/java/ovh/herisson/Clyde/Endpoints/UserControllerTest.java
@ -0,0 +37,4 @@
@Testcontainers
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@ActiveProfiles(value = "dev")
public class UserControllerTest {
Maxime commented 2024-03-18 14:56:48 +01:00
Owner
Copy Link

Manque le test sur le Delete (normal g fini à 00h)

Manque le test sur le Delete (normal g fini à 00h)
LeoMoulin commented 2024-03-18 15:56:08 +01:00
Author
Owner
Copy Link

c'est fait

c'est fait
LeoMoulin added 1 commit 2024-03-18 15:55:43 +01:00
Fix le truc de max et ajoute le test du delete
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m44s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
c7f37b0854
Wal approved these changes 2024-03-18 18:47:48 +01:00
LeoMoulin closed this pull request 2024-03-18 19:18:30 +01:00
LeoMoulin reopened this pull request 2024-03-18 19:18:45 +01:00
LeoMoulin merged commit 66d090d045 into master 2024-03-18 19:21:55 +01:00
LeoMoulin deleted branch Leo/Backend/UnitTest 2024-03-18 19:21:55 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tonitch
Maxime
Wal
Labels
Clear labels   
Bug

   
Done

finie, en attente de validation pour ou pret à la fermeture

  
Pas urgent

A faire que si on a le temps

  
Proposition

   
Question

   
TODO

   
Tests

   
URGENT BORDEL DE Q

   
Waiting for review

   
back

   
front
No Label
Bug
Done
Pas urgent
Proposition
Question
TODO
Tests
URGENT BORDEL DE Q
Waiting for review
back
front
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PGL/Clyde#138
No description provided.
Delete Branch "Leo/Backend/UnitTest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?