PGL/Clyde
PGL/Clyde
3
2
Fork 3
Code Issues 13 Pull Requests Actions Projects 3 Releases 2 Wiki Activity

added ApplicationController and Application enum #119

Merged
tonitch merged 4 commits from Max/Backend/AppsController into master 2024-03-16 14:51:57 +01:00
Conversation 0 Commits 4 Files Changed 1 +6 -6
Maxime commented 2024-03-15 18:56:34 +01:00
Owner
Copy Link

Oui c'est pas bo mais je le ferai plus dynamique avec #112 (mais faut accept curriculum)

Oui c'est pas bo mais je le ferai plus dynamique avec #112 (mais faut accept curriculum)
Maxime added 1 commit 2024-03-15 18:56:36 +01:00
added ApplicationController and Application enum
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m3s
Details
Build and test backend / Test-backend (pull_request) Successful in 2m0s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
1f14890d43
Maxime added the
Done
back
 labels 2024-03-15 18:56:45 +01:00
tonitch reviewed 2024-03-15 22:20:03 +01:00
backend/src/main/java/ovh/herisson/Clyde/EndPoints/ApplicationsController.java Outdated
@ -0,0 +50,4 @@
authorizedApps.add(Applications.FORUM);
authorizedApps.add(Applications.RDV);
if (posterRole == Role.Student || posterRole == Role.Admin) return authorizedApps;
tonitch commented 2024-03-15 22:20:03 +01:00
Owner
Copy Link

cette ligne est un peut bizzare dans le sens ou si il est admin il va retourner direct et par récupérer les autres... Aussi de base msg forum et rdv c'est que pour les student et profs. Si c'est chiant pourquoi pas laisser msg et forum mais rdv c'est spécifique aux profs et etudiants ^^

cette ligne est un peut bizzare dans le sens ou si il est admin il va retourner direct et par récupérer les autres... Aussi de base msg forum et rdv c'est que pour les student et profs. Si c'est chiant pourquoi pas laisser msg et forum mais rdv c'est spécifique aux profs et etudiants ^^
Maxime commented 2024-03-15 23:57:33 +01:00
Author
Owner
Copy Link

petit mistake oui bien vu !

petit mistake oui bien vu !
Maxime marked this conversation as resolved
tonitch reviewed 2024-03-15 22:21:19 +01:00
backend/src/main/java/ovh/herisson/Clyde/Tables/Applications.java Outdated
@ -0,0 +21,4 @@
}
tonitch commented 2024-03-15 22:21:19 +01:00
Owner
Copy Link

Pour le coup je sais que par convention il faudrait les mettre en majuscule parce que c'est des constantes mais vu que je le récupère au niveau backend pour charger les fichiers est-ce qu'il serait possible de faire les noms en PascalCase ?

Pour le coup je sais que par convention il faudrait les mettre en majuscule parce que c'est des constantes mais vu que je le récupère au niveau backend pour charger les fichiers est-ce qu'il serait possible de faire les noms en PascalCase ?
Maxime commented 2024-03-15 23:57:18 +01:00
Author
Owner
Copy Link

Si ça te fait plaisir !

Si ça te fait plaisir !
tonitch commented 2024-03-16 10:12:01 +01:00
Owner
Copy Link

nan en vrai je vais me dermerder sans, j'ai eu d'autre idées pendant la nuit, fait comme tu le pense :D

nan en vrai je vais me dermerder sans, j'ai eu d'autre idées pendant la nuit, fait comme tu le pense :D
tonitch marked this conversation as resolved
Maxime added 1 commit 2024-03-16 00:43:14 +01:00
fixed the GetAuthorizedApps method
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m4s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m59s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
0860567e1b
Maxime added 1 commit 2024-03-16 00:44:52 +01:00
removed the GET /Apps/{id} frontend just iterates on the /apps list
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 2m3s
Details
Build and test backend / Test-backend (pull_request) Successful in 2m2s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
b7b2eafb93
tonitch approved these changes 2024-03-16 10:12:24 +01:00
Wal approved these changes 2024-03-16 10:13:08 +01:00
tonitch added 1 commit 2024-03-16 11:58:06 +01:00
Merge branch 'master' into Max/Backend/AppsController
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m59s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m56s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 24s
Details
abff9aef3a
tonitch added 1 commit 2024-03-16 14:51:24 +01:00
Merge branch 'master' into Max/Backend/AppsController
All checks were successful
Build and test backend / Build-backend (pull_request) Successful in 1m58s
Details
Build and test backend / Test-backend (pull_request) Successful in 1m59s
Details
Build and test FrontEnd / Build-frontend (pull_request) Successful in 25s
Details
182be8ac7b
tonitch merged commit 53e478b05c into master 2024-03-16 14:51:57 +01:00
tonitch deleted branch Max/Backend/AppsController 2024-03-16 14:51:57 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tonitch
Wal
Labels
Clear labels   
Bug

   
Done

finie, en attente de validation pour ou pret à la fermeture

  
Pas urgent

A faire que si on a le temps

  
Proposition

   
Question

   
TODO

   
Tests

   
URGENT BORDEL DE Q

   
Waiting for review

   
back

   
front
No Label
Bug
Done
Pas urgent
Proposition
Question
TODO
Tests
URGENT BORDEL DE Q
Waiting for review
back
front
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PGL/Clyde#119
No description provided.
Delete Branch "Max/Backend/AppsController"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?